Re: [Qemu-devel] [PATCH v2 2/4] Add i.MX I2C controller driver.

[Peter Maydell]

On 5 May 2013 11:53, Peter Crosthwaite <address@hidden> wrote:
> On Sun, May 5, 2013 at 8:47 PM, Peter Maydell <address@hidden> wrote:
>> On 5 May 2013 04:58, Jean-Christophe DUBOIS <address@hidden> wrote:
>>> no extract16() macro spotted.
>>> Should one be added?
>>
>> There's no need for one -- just use extract32. The only
>> reason for having a separate extract64 is to avoid doing
>> 64 bit arithmetic when we don't have to, I think.
>>
>
> perhaps a quick:
>
> #define extract16(a, b, c) (uint16_t)extract32((uint16_t)(a), (b), (c))
>
> would keep the 16bit device code explicit and clean? Save on
> dummy casts in certain situations as well (but not this one).

Hmm, what situations would ever require a cast of the result
or the input of extract32?

-- PMM