Re: [Qemu-devel] [Patch] v2 fix /proc/self/maps output

[Peter Maydell]

On 2 April 2013 13:03, Christophe Lyon <address@hidden> wrote:
> Add a space at end of line when there is no filename to print, to
> conform to linux kernel format (see show_map_vma() in
> fs/proc/task_mmu.c).
>
> Signed-off-by: Christophe Lyon <address@hidden>

Reviewed-by: Peter Maydell <address@hidden>

(CCing Riku and/or trivial might have helped.)

-- PMM


> ---
>
> Changes v1-v2:
> Additional space is now part of the format string.
>
>  linux-user/syscall.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index a148d9f..c3c5c11 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -5013,10 +5013,10 @@ static int open_self_maps(void *cpu_env, int fd)
>          }
>          if (h2g_valid(min) && h2g_valid(max)) {
>              dprintf(fd, TARGET_ABI_FMT_lx "-" TARGET_ABI_FMT_lx
> -                    " %c%c%c%c %08" PRIx64 " %02x:%02x %d%s%s\n",
> +                    " %c%c%c%c %08" PRIx64 " %02x:%02x %d %s%s\n",
>                      h2g(min), h2g(max), flag_r, flag_w,
>                      flag_x, flag_p, offset, dev_maj, dev_min, inode,
> -                    path[0] ? "          " : "", path);
> +                    path[0] ? "         " : "", path);
>          }
>      }
>
> --
> 1.7.10.4
>