Re: [Qemu-devel] [RFC 0/9] QContext: QOM class to support multiple event loops

[Paolo Bonzini]

Il 03/05/2013 18:03, Michael Roth ha scritto:
> These patches apply on top of qemu.git master, and can also be obtained from:
> git://github.com/mdroth/qemu.git qcontext
> 
> OVERVIEW
> 
> This series introduces a set of QOM classes/interfaces for event
> registration/handling: QContext and QSource, which are based closely on
> their GMainContext/GSource GLib counterparts.
> 
> QContexts can be created via the command-line via -object, and can also be
> intructed (via -object params/properties) to automatically start a
> thread/event-loop to handle QSources we attach to them.

This is an awesome idea.

However, it seems a bit overengineered.  Why do we need QSource at all?
 In my opinion, we should first change dataplane to use AioContext as a
GSource, and benchmark it thoroughly.  If it is fast enough, we can
"just" introduce a glib-based QContext and be done with it.  Hopefully
that is the case...

Paolo