Re: [Qemu-devel] [PATCH] memory: Replace open-coded memory_region_is_romd

[Peter Maydell]

On 6 May 2013 17:26, Paolo Bonzini <address@hidden> wrote:
> Il 06/05/2013 18:07, Jan Kiszka ha scritto:
>> Improves readability.
>>
>> Signed-off-by: Jan Kiszka <address@hidden>
>> ---
>>  translate-all.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/translate-all.c b/translate-all.c
>> index da93608..0d84b0d 100644
>> --- a/translate-all.c
>> +++ b/translate-all.c
>> @@ -1359,7 +1359,7 @@ void tb_invalidate_phys_addr(hwaddr addr)
>>      section = phys_page_find(address_space_memory.dispatch,
>>                               addr >> TARGET_PAGE_BITS);
>>      if (!(memory_region_is_ram(section->mr)
>> -          || (section->mr->rom_device && section->mr->readable))) {
>> +          || memory_region_is_romd(section->mr))) {
>>          return;
>>      }
>>      ram_addr = (memory_region_get_ram_addr(section->mr) & TARGET_PAGE_MASK)
>>
>
> Not trivial enough for qemu-trivial, let's open a memory branch for 1.6.

Well, I wouldn't necessarily put it in 1.5 this close to
hardfreeze, but it looks fine for qemu-trivial to me.
In particular you can comprehend the patch and confirm its
correctness without having to have any larger understanding
of the memory system.

Reviewed-by: Peter Maydell <address@hidden>

-- PMM