Re: [Qemu-devel] [PATCH] fdt: update embedded header file from upstream to fix compilation

[Andre Przywara]

On 05/07/2013 02:44 PM, Peter Maydell wrote:
> On 7 May 2013 13:36, Andre Przywara <address@hidden> wrote:
> > Upstream dtc.git introduced a change in libfdt_env.h, which breaks
> > compilation with QEMU's version of it:
> >
> >    CC arm-softmmu/device_tree.o
> > In file included from /usr/include/libfdt.h:55:0,
> >                   from /src/qemu.git/device_tree.c:28:
> > /usr/include/fdt.h:7:2: error: unknown type name 'fdt32_t'
> >     ...
>
> I'm not entirely sure I understand why we need change.
> Have upstream really introduced a breaking change for
> everybody who uses libfdt, or are we using it wrongly?

Everybody who copies and changes a header from the original distribution 
and uses this now instead of the installed version ;-)

libfdt (or better: dtc) seems to be quite out of date in the official 
distribution packages. I just happened to have git HEAD installed manually.

Regards,
Andre.