Re: [Qemu-devel] [PATCH] Add 'maxqdepth' as an option to tty character devices.

[John Baboval]

Sorry about fumbling with the tools. The wiki link is very helpful. I'll give 
it another go in a little while.

-----Original Message-----
From: Eric Blake [mailto:address@hidden 
Sent: Tuesday, May 07, 2013 1:17 PM
To: John Baboval
Cc: address@hidden; John Baboval
Subject: Re: [Qemu-devel] [PATCH] Add 'maxqdepth' as an option to tty character 
devices.

On 05/07/2013 10:51 AM, John Baboval wrote:
> From: "John V. Baboval" <address@hidden>
> 
> This parameter will cause writes to tty backed chardevs to return 
> -EAGAIN if the backing tty has buffered more than the specified number 
> of characters. When data is sent, the TIOCOUTQ ioctl is invoked to 
> determine the current TTY output buffer depth.

When submitting a v2 patch, please adjust the subject line to call out that it 
is a v2, and send it as a top-level thread rather than in-reply-to an earlier 
thread.  For more details, see:

http://wiki.qemu.org/Contribute/SubmitAPatch

> +++ b/qapi-schema.json
> @@ -3182,11 +3182,14 @@
>  #
>  # @device: The name of the special file for the device,
>  #          i.e. /dev/ttyS0 on Unix or COM1: on Windows
> +# @maxqdepth: The maximum depth of the underlying tty
> +              output queue (Unix)
>  # @type: What kind of device this is.
>  #
>  # Since: 1.4
>  ##
> -{ 'type': 'ChardevHostdev', 'data': { 'device' : 'str' } }
> +{ 'type': 'ChardevHostdev', 'data': { 'device'    : 'str',
> +                                      'maxqdepth' : 'int' } }

You did not address any of my review concerns from v1, such as listing a (since 
1.6) label or marking maxqdepth as optional.  Are you sure you sent the right 
patch?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org