[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/40] memory: create FlatView for new address s
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 09/40] memory: create FlatView for new address spaces |
Date: |
Wed, 8 May 2013 04:41:59 -0400 (EDT) |
> On 7 May 2013 15:16, Paolo Bonzini <address@hidden> wrote:
> > A new address space has an empty FlatView. In order to create it, we
> > must (a) call memory_region_transaction_commit after the address space is
> > inserted into the list; (b) force memory_region_transaction_commit to
> > do something.
> >
> > This bug was latent so far because all address spaces started empty,
> > including
> > the PCI address space where the bus master region is initially disabled.
> > However, the target address space of an IOMMU is usually rooted at
> > get_system_memory(), which might not be empty at the time the IOMMU is
> > created.
>
> The code looks ok but I don't entirely understand the
> commit message. Surely we're definitely already creating
> the FlatView -- that's what the g_new and flatview_init do.
> What we're not doing is calling notifiers for the initial
> contents of the address space, right? (and thus in turn
> we're not setting up the data structures those notifiers
> control, but as far as I can see from the code that's not
> the FlatView.)
Right, it should be s/create/populate/g.
Paolo
- [Qemu-devel] [PATCH 07/40] memory: fix address space initialization/destruction, (continued)
[Qemu-devel] [PATCH 09/40] memory: create FlatView for new address spaces, Paolo Bonzini, 2013/05/07
[Qemu-devel] [PATCH 38/40] memory: access FlatView from a local variable, Paolo Bonzini, 2013/05/07
[Qemu-devel] [PATCH 37/40] memory: ref/unref memory across address_space_map/unmap, Paolo Bonzini, 2013/05/07
[Qemu-devel] [PATCH 33/40] pci-assign: add memory_region_set_owner calls, Paolo Bonzini, 2013/05/07
[Qemu-devel] [PATCH 31/40] isa/portio: allow setting an owner, Paolo Bonzini, 2013/05/07
[Qemu-devel] [PATCH 36/40] memory: return MemoryRegion from qemu_ram_addr_from_host, Paolo Bonzini, 2013/05/07
[Qemu-devel] [PATCH 35/40] exec: check MRU in qemu_ram_addr_from_host, Paolo Bonzini, 2013/05/07
[Qemu-devel] [PATCH 34/40] vfio: add memory_region_set_owner calls, Paolo Bonzini, 2013/05/07
[Qemu-devel] [PATCH 39/40] memory: use a new FlatView pointer on every topology update, Paolo Bonzini, 2013/05/07
[Qemu-devel] [PATCH 01/40] memory: assert that PhysPageEntry's ptr does not overflow, Paolo Bonzini, 2013/05/07