Re: [Qemu-devel] [PATCH] PPC: Depend behavior of cmp instructions only on instruction encoding

[Torbjorn Granlund]

Alexander Graf <address@hidden> writes:

  Reported-by: Torbjorn Granlund <address@hidden>
  Signed-off-by: Alexander Graf <address@hidden>

Ah, so my original patch was correct after all.
Only the name of the author needed changing, apparently.  :-)

  ---
   target-ppc/translate.c |    8 ++++----
   1 files changed, 4 insertions(+), 4 deletions(-)
  
  diff --git a/target-ppc/translate.c b/target-ppc/translate.c
  index a018616..89a4445 100644
  --- a/target-ppc/translate.c
  +++ b/target-ppc/translate.c
  @@ -675,7 +675,7 @@ static inline void gen_set_Rc0(DisasContext *ctx, TCGv 
reg)
   /* cmp */
   static void gen_cmp(DisasContext *ctx)
   {
  -    if (NARROW_MODE(ctx) || !(ctx->opcode & 0x00200000)) {
  +    if (!(ctx->opcode & 0x00200000)) {
           gen_op_cmp32(cpu_gpr[rA(ctx->opcode)], cpu_gpr[rB(ctx->opcode)],
                        1, crfD(ctx->opcode));
       } else {
  @@ -687,7 +687,7 @@ static void gen_cmp(DisasContext *ctx)
   /* cmpi */
   static void gen_cmpi(DisasContext *ctx)
   {
  -    if (NARROW_MODE(ctx) || !(ctx->opcode & 0x00200000)) {
  +    if (!(ctx->opcode & 0x00200000)) {
           gen_op_cmpi32(cpu_gpr[rA(ctx->opcode)], SIMM(ctx->opcode),
                         1, crfD(ctx->opcode));
       } else {
  @@ -699,7 +699,7 @@ static void gen_cmpi(DisasContext *ctx)
   /* cmpl */
   static void gen_cmpl(DisasContext *ctx)
   {
  -    if (NARROW_MODE(ctx) || !(ctx->opcode & 0x00200000)) {
  +    if (!(ctx->opcode & 0x00200000)) {
           gen_op_cmp32(cpu_gpr[rA(ctx->opcode)], cpu_gpr[rB(ctx->opcode)],
                        0, crfD(ctx->opcode));
       } else {
  @@ -711,7 +711,7 @@ static void gen_cmpl(DisasContext *ctx)
   /* cmpli */
   static void gen_cmpli(DisasContext *ctx)
   {
  -    if (NARROW_MODE(ctx) || !(ctx->opcode & 0x00200000)) {
  +    if (!(ctx->opcode & 0x00200000)) {
           gen_op_cmpi32(cpu_gpr[rA(ctx->opcode)], UIMM(ctx->opcode),
                         0, crfD(ctx->opcode));
       } else {

Hopefully my cmp speedup patch will be reposted under a new name and
then included.

-- 
Torbjörn