[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ahci: Don't allow creating slave drives
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH] ahci: Don't allow creating slave drives |
|
Date: |
Wed, 8 May 2013 16:29:07 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, May 06, 2013 at 04:02:58PM +0200, Kevin Wolf wrote:
> An IDE bus provided by AHCI can only take a single IDE drive. If you add
> a drive as slave, qemu used to accept the command line but the device
> wouldn't be actually usable. Catch the situation instead and error out.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> hw/ide/ahci.c | 2 +-
> hw/ide/cmd646.c | 2 +-
> hw/ide/internal.h | 3 ++-
> hw/ide/isa.c | 2 +-
> hw/ide/macio.c | 2 +-
> hw/ide/mmio.c | 2 +-
> hw/ide/piix.c | 2 +-
> hw/ide/qdev.c | 10 +++++++++-
> hw/ide/via.c | 2 +-
> 9 files changed, 18 insertions(+), 9 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>