Re: [Qemu-devel] [PATCH 9/9] Make monitor command 'dump-guest-memory' dump in kdump-compressed format

[Zhang Xiaohe]

于 2013年05月09日 01:16, Eric Blake 写道:
> On 05/08/2013 02:50 AM, qiaonuohan wrote:
> > Thanks for your suggestion. I will fix it like:
> >
> > { 'enum': 'DumpCompressionFormat',
> >    'data': [ 'zlib', 'lzo', 'snappy' ] }
> >
> > For zlib is treated as the default compression format, and
> > 'uncompressed' won't be an option.
>
> No, I was serious that you need to provide 'uncompressed' as an explicit
> enum value.  It is very annoying to toggle between four states (three
> compression formats and a fourth state of no compression) when the
> fourth is available only by omitting a parameter.  The default MUST be
> 'uncompressed' for backwards-compatibility, not 'zlib'.
We'd like to make sure that we understand you precisely.

The definion is like below:
{ 'enum': 'DumpGuestMemoryFormat',
  'data': [ 'uncompressed', 'zlib', 'lzo', 'snappy' ] }

{ 'command': 'dump-guest-memory',
  'data': { 'paging': 'bool', 'protocol': 'str', '*begin': 'int',
            '*length': 'int', '*format': 'DumpCompressionFormat' } }

'format' is optional:
1. when 'format' is not specified, vmcore will be in ELF format.
2. when 'format' is specified and its parameter is 'uncompressed',
   vmcore will be in ELF format as well.
3. when 'format' is specified and its parameter is 'zlib/lzo/snappy',
   vmcore will be in kdump-compressed format.

If this is what you suggest, then I don't think it is necessary to
add 'uncompressed'. The backwards-compatibility is assured by case 1,
in which the interface is exactly the same as before. So why do we
add another parameter to do the same thing again?