[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command |
Date: |
Fri, 10 May 2013 22:02:14 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5 |
On 04/29/2013 01:42 AM, Stefan Hajnoczi wrote:
> @block-backup
>
> +++ b/qapi-schema.json
> @@ -1715,6 +1715,37 @@
> '*speed': 'int' } }
>
> ##
> +# @block-backup
> +#
> +# Start a point-in-time copy of a block device to a new destination. The
> +# status of ongoing block backup operations can be checked with
> +# query-block-jobs. The operation can be stopped before it has completed
> using
> +# the block-job-cancel command.
Still might be worth mentioning that 'query-block-jobs' will list it as
a job of type 'backup'.
> +#
> +# @device: the name of the device whose writes should be mirrored.
> +#
> +# @target: the target of the new image. If the file exists, or if it
> +# is a device, the existing file/device will be used as the new
> +# destination. If it does not exist, a new file will be created.
> +#
> +# @format: #optional the format of the new destination, default is to
> +# probe if @mode is 'existing', else the format of the source
> +#
> +# @mode: #optional whether and how QEMU should create a new image, default is
> +# 'absolute-paths'.
> +#
> +# @speed: #optional the maximum speed, in bytes per second
> +#
> +# Returns: nothing on success
> +# If @device is not a valid block device, DeviceNotFound
> +#
> +# Since 1.6
> +##
> +{ 'command': 'block-backup',
> + 'data': { 'device': 'str', 'target': 'str', '*format': 'str',
Hmm - wondering if we should add an enum type for supported disk formats
instead of using free-form strings. The wire representation would be
the same, and now's the time to do it before we add introspection (it's
more than just this command impacted).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 0/3] block: block-backup live backup command, Stefan Hajnoczi, 2013/05/01
- [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command, Stefan Hajnoczi, 2013/05/01
- Re: [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command,
Eric Blake <=
- Re: [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command, Kevin Wolf, 2013/05/13
- Re: [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command, Eric Blake, 2013/05/13
- Re: [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command, Kevin Wolf, 2013/05/13
- Re: [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command, Luiz Capitulino, 2013/05/13
- Re: [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command, Eric Blake, 2013/05/13
- Re: [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command, Kevin Wolf, 2013/05/13
- Re: [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command, Eric Blake, 2013/05/13
- Re: [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command, Wenchao Xia, 2013/05/13
- Re: [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command, Stefan Hajnoczi, 2013/05/14
[Qemu-devel] [PATCH v2 1/3] block: add basic backup support to block driver, Stefan Hajnoczi, 2013/05/01