[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] arch_init/ram_load: add error message for bl
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH v3] arch_init/ram_load: add error message for block length mismatch |
Date: |
Mon, 13 May 2013 10:57:57 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Alon Levy <address@hidden> wrote:
> Makes it easier to debug situations where the source and target have
> different ram blocks in a device and migration fails due to that, for
> instance a BAR size change on a PCI device.
>
> Signed-off-by: Alon Levy <address@hidden>
> ---
> v3: use RAM_ADDR_FMT
>
> arch_init.c | 3 +++
> 1 file changed, 3 insertions(+)
>
Reviewed-by: Juan Quintela <address@hidden>
will be included in next pull request. thanks.
> diff --git a/arch_init.c b/arch_init.c
> index 49c5dc2..cd27fcf 100644
> --- a/arch_init.c
> +++ b/arch_init.c
> @@ -808,6 +808,9 @@ static int ram_load(QEMUFile *f, void *opaque, int
> version_id)
> QTAILQ_FOREACH(block, &ram_list.blocks, next) {
> if (!strncmp(id, block->idstr, sizeof(id))) {
> if (block->length != length) {
> + fprintf(stderr, "Length mismatch: %s: %ld "
> + "in != " RAM_ADDR_FMT "\n", id,
> length,
> + block->length);
> ret = -EINVAL;
> goto done;
> }