qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC 5/7] sd.c: introduce async read operation


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [RFC 5/7] sd.c: introduce async read operation
Date: Mon, 13 May 2013 14:10:09 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Fri, May 10, 2013 at 08:10:23PM +0400, Igor Mitsyanko wrote:
> +    if (sd->state != sd_sendingdata_state) {
> +        DPRINTF("Transfer was aborted\n");
> +        return;
> +    }
> +
> +    io_len = (sd->ocr & (1 << 30)) ? 512 : sd->blk_len;

If you respin, a constant would be nice instead of the 1 << 30 magic
number.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]