[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] blockdev: Rename BlockdevAction -> TransactionA
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] blockdev: Rename BlockdevAction -> TransactionAction |
Date: |
Mon, 13 May 2013 06:51:06 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5 |
On 05/13/2013 02:46 AM, Kevin Wolf wrote:
> There's no reason to restrict transactions to operations related to
> block devices, so rename the type now before schema introspection stops
> us from doing so.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> blockdev.c | 22 +++++++++++-----------
> qapi-schema.json | 8 ++++----
> 2 files changed, 15 insertions(+), 15 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
However,
> #
> # List of:
> -# @BlockdevAction: information needed for the device snapshot
> +# @TransactionAction: information needed for the device snapshot
Is this comment now out of date?
> #
> # Returns: nothing on success
> # If @device is not a valid block device, DeviceNotFound
> @@ -1640,7 +1640,7 @@
> # Since 1.1
> ##
> { 'command': 'transaction',
> - 'data': { 'actions': [ 'BlockdevAction' ] } }
> + 'data': { 'actions': [ 'TransactionAction' ] } }
>
> ##
> # @blockdev-snapshot-sync
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature