[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 02/11] curl: change magic number to macro
From: |
Fam Zheng |
Subject: |
[Qemu-devel] [PATCH v2 02/11] curl: change magic number to macro |
Date: |
Tue, 14 May 2013 10:26:21 +0800 |
String field length is duplicated in two places. Make it a macro.
Signed-off-by: Fam Zheng <address@hidden>
---
block/curl.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/block/curl.c b/block/curl.c
index 14f4552..aa78086 100644
--- a/block/curl.c
+++ b/block/curl.c
@@ -70,7 +70,8 @@ typedef struct CURLState
size_t buf_start;
size_t buf_off;
size_t buf_len;
- char range[128];
+#define CURL_RANGE_SIZE 128
+ char range[CURL_RANGE_SIZE];
char errmsg[CURL_ERROR_SIZE];
char in_use;
} CURLState;
@@ -567,7 +568,7 @@ static void curl_readv_bh_cb(void *p)
state->orig_buf = g_malloc(state->buf_len);
state->acb[0] = acb;
- snprintf(state->range, 127, "%zd-%zd", start, end);
+ snprintf(state->range, CURL_RANGE_SIZE - 1, "%zd-%zd", start, end);
DPRINTF("CURL (AIO): Reading %d at %zd (%s)\n",
(acb->nb_sectors * SECTOR_SIZE), start, state->range);
curl_easy_setopt(state->curl, CURLOPT_RANGE, state->range);
--
1.8.1.4
- [Qemu-devel] [PATCH v2 00/11] curl: fix curl read, Fam Zheng, 2013/05/13
- [Qemu-devel] [PATCH v2 01/11] curl: introduce CURLSockInfo to BDRVCURLState., Fam Zheng, 2013/05/13
- [Qemu-devel] [PATCH v2 02/11] curl: change magic number to macro,
Fam Zheng <=
- [Qemu-devel] [PATCH v2 03/11] curl: change curl_multi_do to curl_fd_handler, Fam Zheng, 2013/05/13
- [Qemu-devel] [PATCH v2 04/11] curl: fix curl_open, Fam Zheng, 2013/05/13
- [Qemu-devel] [PATCH v2 05/11] curl: add timer to BDRVCURLState, Fam Zheng, 2013/05/13
- [Qemu-devel] [PATCH v2 06/11] curl: introduce CURLDataCache, Fam Zheng, 2013/05/13
- [Qemu-devel] [PATCH v2 07/11] curl: make use of CURLDataCache., Fam Zheng, 2013/05/13
- [Qemu-devel] [PATCH v2 08/11] curl: use list to store CURLState, Fam Zheng, 2013/05/13
- [Qemu-devel] [PATCH v2 09/11] curl: release everything on curl_close, Fam Zheng, 2013/05/13