qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH v2 02/11] curl: change magic number to macro


From: Fam Zheng
Subject: [Qemu-devel] [PATCH v2 02/11] curl: change magic number to macro
Date: Tue, 14 May 2013 10:26:21 +0800

String field length is duplicated in two places. Make it a macro.

Signed-off-by: Fam Zheng <address@hidden>
---
 block/curl.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/block/curl.c b/block/curl.c
index 14f4552..aa78086 100644
--- a/block/curl.c
+++ b/block/curl.c
@@ -70,7 +70,8 @@ typedef struct CURLState
     size_t buf_start;
     size_t buf_off;
     size_t buf_len;
-    char range[128];
+#define CURL_RANGE_SIZE 128
+    char range[CURL_RANGE_SIZE];
     char errmsg[CURL_ERROR_SIZE];
     char in_use;
 } CURLState;
@@ -567,7 +568,7 @@ static void curl_readv_bh_cb(void *p)
     state->orig_buf = g_malloc(state->buf_len);
     state->acb[0] = acb;
 
-    snprintf(state->range, 127, "%zd-%zd", start, end);
+    snprintf(state->range, CURL_RANGE_SIZE - 1, "%zd-%zd", start, end);
     DPRINTF("CURL (AIO): Reading %d at %zd (%s)\n",
             (acb->nb_sectors * SECTOR_SIZE), start, state->range);
     curl_easy_setopt(state->curl, CURLOPT_RANGE, state->range);
-- 
1.8.1.4




reply via email to

[Prev in Thread] Current Thread [Next in Thread]