[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 10/13] i386: generate pc guest info
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH RFC 10/13] i386: generate pc guest info |
Date: |
Tue, 14 May 2013 11:06:22 +0300 |
On Mon, May 13, 2013 at 09:23:54PM +0100, Peter Maydell wrote:
> On 13 May 2013 21:01, Michael S. Tsirkin <address@hidden> wrote:
> > This fills in guest info table with misc
> > information of interest to the guest.
> > Will be used by ACPI table generation code.
>
> Bunch of coding style violations in this patch which will
> need fixing at some point in the RFC->patch process.
>
> thanks
> -- PMM
I went over it again and found one:
+ if (ram_size <= 0x80000000)
+ guest_info->pci_info.w32.begin = 0x80000000;
+ else if (ram_size <= 0xc0000000)
+ guest_info->pci_info.w32.begin = 0xc0000000;
+ else
+ guest_info->pci_info.w32.begin = 0xe0000000;
should use {}.
One is not a bunch so I obviously missed some - it might be helpful if
you pointed them out.
Thanks,
--
MST
- [Qemu-devel] [PATCH RFC 06/13] acpi: add rules to compile ASL source, (continued)
- [Qemu-devel] [PATCH RFC 06/13] acpi: add rules to compile ASL source, Michael S. Tsirkin, 2013/05/13
- [Qemu-devel] [PATCH RFC 05/13] i386: add ACPI table files from seabios, Michael S. Tsirkin, 2013/05/13
- [Qemu-devel] [PATCH RFC 08/13] range: add Range structure, Michael S. Tsirkin, 2013/05/13
- [Qemu-devel] [PATCH RFC 13/13] pc: reuse guest info for legacy fw cfg, Michael S. Tsirkin, 2013/05/13
- [Qemu-devel] [PATCH RFC 09/13] i386: add bios linker/loader, Michael S. Tsirkin, 2013/05/13
- [Qemu-devel] [PATCH RFC 07/13] acpi: pre-compiled ASL files, Michael S. Tsirkin, 2013/05/13
- [Qemu-devel] [PATCH RFC 10/13] i386: generate pc guest info, Michael S. Tsirkin, 2013/05/13
- [Qemu-devel] [PATCH RFC 11/13] pc: pass PCI hole ranges to Guests, Michael S. Tsirkin, 2013/05/13
- [Qemu-devel] [PATCH RFC 12/13] i386: ACPI table generation code from seabios, Michael S. Tsirkin, 2013/05/13
- Re: [Qemu-devel] [PATCH RFC 00/13] qemu: generate acpi tables for the guest, Anthony Liguori, 2013/05/13