[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 02/11] pci: Don't del_subgregion on a non subregion
From: |
David Gibson |
Subject: |
[Qemu-devel] [PATCH 02/11] pci: Don't del_subgregion on a non subregion |
Date: |
Tue, 14 May 2013 19:13:48 +1000 |
Currently do_pci_unregister_device() calls memory_region_del_subregion()
on the device's bus_master_enable_region and the device's iommu region.
But the bus_master_enable_region is an _alias_ to the iommu region, the
iommu region is _not_ a subregion of it. I suspect this has slipped by
only because PCI hot unplug has not been tested with the new PCI DMA
address space handling. This patch removes the bogus call.
Signed-off-by: David Gibson <address@hidden>
---
hw/pci/pci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 0ba39e6..58d3f69 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -875,7 +875,6 @@ static void do_pci_unregister_device(PCIDevice *pci_dev)
pci_config_free(pci_dev);
address_space_destroy(&pci_dev->bus_master_as);
- memory_region_del_subregion(&pci_dev->bus_master_enable_region,
pci_dev->iommu);
pci_dev->bus->iommu_dtor_fn(pci_dev->iommu);
memory_region_destroy(&pci_dev->bus_master_enable_region);
}
--
1.7.10.4
- [Qemu-devel] [0/11] RFC: VFIO and guest side IOMMUs, version 3, David Gibson, 2013/05/14
- [Qemu-devel] [PATCH 02/11] pci: Don't del_subgregion on a non subregion,
David Gibson <=
- [Qemu-devel] [PATCH 01/11] iommu: Fix compile error in ioapic.c, David Gibson, 2013/05/14
- [Qemu-devel] [PATCH 04/11] pci: Use AddressSpace rather than MemoryRegion to represent PCI DMA space, David Gibson, 2013/05/14
- [Qemu-devel] [PATCH 03/11] pci: Rework PCI iommu lifetime assumptions, David Gibson, 2013/05/14
- [Qemu-devel] [PATCH 09/11] memory: Add iova to IOMMUTLBEntry, David Gibson, 2013/05/14
- [Qemu-devel] [PATCH 05/11] pci: Introduce helper to retrieve a PCI device's DMA address space, David Gibson, 2013/05/14
- [Qemu-devel] [PATCH 06/11] memory: Sanity check that no listeners remain on a destroyed AddressSpace, David Gibson, 2013/05/14
- [Qemu-devel] [PATCH 07/11] vfio: Introduce VFIO address spaces, David Gibson, 2013/05/14