[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH moxie] Fix bug in tlb_fill.
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH moxie] Fix bug in tlb_fill. |
|
Date: |
Tue, 14 May 2013 09:02:32 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5 |
On 05/13/2013 01:33 PM, Max Filippov wrote:
> memory access at points (1) and (2) can abort the instruction (it did so
> b/o the bug, but it may do so legitimately when you add MMU support),
> but it has modified REG(1) at those points, which will not be restored.
> It's probably worth carrying register modifications in some temporary
> until after the point (2).
... Which you'll recall that I pointed out during initial review, AG.
r~