Re: [Qemu-devel] [PATCH for-1.5 2/2] osdep: introduce qemu_anon_ram_free to free qemu_anon_ram_alloc-ed memory

[Markus Armbruster]

This patch would break the build for me, if I didn't configure
--disable-werror.  Using --enable-trace-backend=stderr in case it makes
a difference.  Troublemaker flagged inline.

Paolo Bonzini <address@hidden> writes:

> We switched from qemu_memalign to mmap() but then we don't modify
> qemu_vfree() to do a munmap() over free().  Which we cannot do
> because qemu_vfree() frees memory allocated by qemu_{mem,block}align.
>
> Introduce a new function that does the munmap(), luckily the size is
> available in the RAMBlock.
[...]
> diff --git a/trace-events b/trace-events
> index acf0f5c..c7dbcf0 100644
> --- a/trace-events
> +++ b/trace-events
> @@ -34,6 +34,7 @@ g_free(void *ptr) "ptr %p"
>  qemu_memalign(size_t alignment, size_t size, void *ptr) "alignment %zu size 
> %zu ptr %p"
>  qemu_anon_ram_alloc(size_t size, void *ptr) "size %zu ptr %p"
>  qemu_vfree(void *ptr) "ptr %p"
> +qemu_anon_ram_free(void *ptr, size_t size) "size %zu ptr %p"

In file included from /work/armbru/qemu/include/trace.h:4:0,
                 from /work/armbru/qemu/util/osdep.c:49:
./trace/generated-tracers.h: In function 'trace_qemu_anon_ram_free':
./trace/generated-tracers.h:64:9: warning: format '%zu' expects argument of 
type 'size_t', but argument 3 has type 'void *' [-Wformat]
./trace/generated-tracers.h:64:9: warning: format '%p' expects argument of type 
'void *', but argument 4 has type 'size_t' [-Wformat]


>  
>  # hw/virtio.c
>  virtqueue_fill(void *vq, const void *elem, unsigned int len, unsigned int 
> idx) "vq %p elem %p len %u idx %u"
[...]