Re: [Qemu-devel] [PATCH for-1.5?] ide-test: Fix endianness problems

[mdroth]

On Wed, May 15, 2013 at 10:37:43AM -0500, Anthony Liguori wrote:
> Paolo Bonzini <address@hidden> writes:
> 
> > Il 15/05/2013 15:24, Kevin Wolf ha scritto:
> >> Am 15.05.2013 um 15:15 hat Paolo Bonzini geschrieben:
> >>> Il 15/05/2013 15:00, Kevin Wolf ha scritto:
> >>>> The test case passes on big endian hosts now (tested on ppc64)
> >>>>
> >>>> Signed-off-by: Kevin Wolf <address@hidden>
> >>>
> >>> For 1.5?  Do we need an extra -rc?
> >> 
> >> An extra -rc for a test case fix on big endian hosts is probably too
> >> much... But if it can still be applied for the release, sure, why not.
> >
> > Well, we have Mac OS X not building,
> 
> Peter's patch fixes it and will be in -rc2
> 
> > BSDs not supporting the GTK+
> 
> We don't have a formal support statement, but I don't think it's
> controversial to say that BSD hosts are a secondary platform from a host
> point of view.
> 
> A build issue in an optional feature on a secondary platform is not
> something I'd consider a release blocker.
> 
> > release, and SLIRP broken on Windows.
> 
> This is a tough one since it's the default networking backend.  That
> said, it likely has been broken for a while (months) and no one
> noticed.  That makes me think that fixing in stable (particularly if we
> scheduled a stable release for two weeks after 1.5.0) is reasonable.

This is a bit tight. Freeze for 1.4.2 is the same day as 1.5.0, so we'd
be testing 2 stable releases at the same time.

So if we do this, I think it we should restrict it to fixing the specific
issues we're considering as potential 1.5.0 release blockers so we can
focus on those in testing rather than opening it up for general fixes.

> 
> Regards,
> 
> Anthony Liguori
> 
> >  At least the first two have
> > patches on the list, the last is bisected but no patch yet.
> >
> > Paolo
>