[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 5/8] blockdev: rename BlkTransactionStates to
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 5/8] blockdev: rename BlkTransactionStates to singular |
Date: |
Wed, 15 May 2013 13:09:47 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5 |
On 05/15/2013 08:34 AM, Stefan Hajnoczi wrote:
> The QMP 'transaction' command keeps a list of in-flight transactions.
> The transaction state structure is called BlkTransactionStates even
> though it only deals with a single transaction. The only plural thing
> is the linked list of transaction states.
>
> I find it confusing to call the single structure "States". This patch
> renames it to "State", just like BlockDriverState is singular.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> blockdev.c | 104
> ++++++++++++++++++++++++++++++-------------------------------
> 1 file changed, 52 insertions(+), 52 deletions(-)
Mechanical, and singular makes sense to me (for a given callback, you
are dealing with the single state for that callback, not all the states
chained into the transaction).
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 8/8] qemu-iotests: test 'drive-backup' transaction in 055, (continued)
- [Qemu-devel] [PATCH v3 8/8] qemu-iotests: test 'drive-backup' transaction in 055, Stefan Hajnoczi, 2013/05/15
- [Qemu-devel] [PATCH v3 6/8] blockdev: add DriveBackup transaction, Stefan Hajnoczi, 2013/05/15
- [Qemu-devel] [PATCH v3 4/8] qemu-iotests: add 055 drive-backup test case, Stefan Hajnoczi, 2013/05/15
- [Qemu-devel] [PATCH v3 1/8] block: add bdrv_add_before_write_cb(), Stefan Hajnoczi, 2013/05/15
- [Qemu-devel] [PATCH v3 5/8] blockdev: rename BlkTransactionStates to singular, Stefan Hajnoczi, 2013/05/15
- [Qemu-devel] [PATCH v3 3/8] block: add drive-backup QMP command, Stefan Hajnoczi, 2013/05/15
- [Qemu-devel] [PATCH v3 2/8] block: add basic backup support to block driver, Stefan Hajnoczi, 2013/05/15