Re: [Qemu-devel] [PATCH] scsi: reset cdrom tray statuses on scsi_disk_reset

[Pavel Hrdina]

On 16.5.2013 17:42, Eric Blake wrote:
> On 05/16/2013 09:34 AM, Pavel Hrdina wrote:
> > Tray statuses should be also reseted. Some guests may lock the tray
>
> s/reseted/reset/
>
> > and after reset before any kernel is loaded the tray should be unlocked.
> >
> > Also if you reset the real computer the tray is closed. We should
> > do the same in qemu.
>
> Is that OS-independent hardware behavior, or is tray closing on boot
> merely a side effect observed on bare metal but caused by installed
> software (BIOS or OS code)?  At any rate, being consistent with IDE
> doesn't hurt.

From what I just tested it is the OS-independent HW behavior.

Tested on desktop:
1. Turn off the computer.
2. Turn on the computer and after few second open the CD-ROM tray before 
any OS system is loaded and holding the power button turn the computer 
off again. The CD-ROM tray should stay opened.
3. Turn on the computer and the CD-ROM tray is automatically closed.

Next time I'll mention this test in the commit message.

> > This fix is already commited for IDE CD.
>
> s/commited/committed/
>
> > Check the commit a7f3d65b65b8c86a5ff0c0abcfefb45e2ec6fe4c.
> >
> > Signed-off-by: Pavel Hrdina <address@hidden>
> > ---
> >   hw/scsi/scsi-disk.c | 3 +++
> >   1 file changed, 3 insertions(+)
>
> assuming the maintainer can touch up the commit message, feel free to add:
>
> Reviewed-by: Eric Blake <address@hidden>