[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files |
Date: |
Wed, 22 May 2013 11:48:54 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, May 22, 2013 at 12:46:45AM +0300, Michael S. Tsirkin wrote:
> Once in a while make gets killed and doesn't
> clean up partial object files after it.
> Result is nasty errors from link.
> This hack checks object is well formed before linking,
> and rebuilds it if not.
>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
>
> Is below useful for others?
>
> Makefile.target | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Makefile.target b/Makefile.target
> index ce4391f..4dddee5 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -191,3 +191,10 @@ endif
>
> GENERATED_HEADERS += config-target.h
> Makefile: $(GENERATED_HEADERS)
> +
> +.SECONDEXPANSION:
> +
> +.PHONY: CORRUPTBINARY
> +
> +$(all-obj-y): % : $$(if $$(shell size %), , CORRUPTBINARY)
How does size(1) establish the validity of the ELF file? Is it possible
to sneak past a truncated file (which I think is the only type of
corruption you're trying to protect against)?
Stefan
- Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files, (continued)
- Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files, Peter Maydell, 2013/05/26
- Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files, Michael S. Tsirkin, 2013/05/26
- Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files, Blue Swirl, 2013/05/26
- Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files, Michael S. Tsirkin, 2013/05/26
- Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files, Blue Swirl, 2013/05/26
- Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files, Michael S. Tsirkin, 2013/05/26
- Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files, Blue Swirl, 2013/05/26
- Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files, Michael S. Tsirkin, 2013/05/26
- Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files, Anthony Liguori, 2013/05/26
- Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files, Michael S. Tsirkin, 2013/05/22
Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files,
Stefan Hajnoczi <=