qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 01/11] curl: introduce CURLSockInfo to BDRVCU


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH v5 01/11] curl: introduce CURLSockInfo to BDRVCURLState.
Date: Thu, 23 May 2013 15:44:05 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Thu, May 23, 2013 at 11:37:59AM +0800, Fam Zheng wrote:
> @@ -90,7 +98,16 @@ static int curl_aio_flush(void *opaque);
>  static int curl_sock_cb(CURL *curl, curl_socket_t fd, int action,
>                          void *s, void *sp)
>  {
> +    BDRVCURLState *bs = s;

bs is used for BlockDriverState in block/* code.  I find this confusing.
Usually the custom state is called 's'.  Perhaps just rename the void*
arguments s_ and sp_.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]