[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 01/11] curl: introduce CURLSockInfo to BDRVCU
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v5 01/11] curl: introduce CURLSockInfo to BDRVCURLState. |
Date: |
Thu, 23 May 2013 15:44:05 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, May 23, 2013 at 11:37:59AM +0800, Fam Zheng wrote:
> @@ -90,7 +98,16 @@ static int curl_aio_flush(void *opaque);
> static int curl_sock_cb(CURL *curl, curl_socket_t fd, int action,
> void *s, void *sp)
> {
> + BDRVCURLState *bs = s;
bs is used for BlockDriverState in block/* code. I find this confusing.
Usually the custom state is called 's'. Perhaps just rename the void*
arguments s_ and sp_.
- [Qemu-devel] [PATCH v5 00/11] curl: fix curl read, Fam Zheng, 2013/05/22
- [Qemu-devel] [PATCH v5 01/11] curl: introduce CURLSockInfo to BDRVCURLState., Fam Zheng, 2013/05/22
- Re: [Qemu-devel] [PATCH v5 01/11] curl: introduce CURLSockInfo to BDRVCURLState.,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH v5 02/11] curl: change magic number to sizeof, Fam Zheng, 2013/05/22
- [Qemu-devel] [PATCH v5 03/11] curl: change curl_multi_do to curl_fd_handler, Fam Zheng, 2013/05/22
- [Qemu-devel] [PATCH v5 04/11] curl: fix curl_open, Fam Zheng, 2013/05/22
- [Qemu-devel] [PATCH v5 05/11] curl: add timer to BDRVCURLState, Fam Zheng, 2013/05/22
- [Qemu-devel] [PATCH v5 06/11] curl: introduce CURLDataCache, Fam Zheng, 2013/05/22
- [Qemu-devel] [PATCH v5 07/11] curl: make use of CURLDataCache., Fam Zheng, 2013/05/22