[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 02/12] qapi: qapi-visit.py, fix list handling for uni
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] [PULL 02/12] qapi: qapi-visit.py, fix list handling for union types |
Date: |
Thu, 23 May 2013 14:20:22 -0400 |
From: Michael Roth <address@hidden>
Currently we assume non-list types when generating visitor routines for
union types. This is broken, since values like ['Type'] need to mapped
to 'TypeList'.
We already have a type_name() function to handle this that we use for
generating struct visitors, so use that here as well.
Signed-off-by: Michael Roth <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Reviewed-by: Amos Kong <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>
---
scripts/qapi-visit.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py
index a276540..4c4de4b 100644
--- a/scripts/qapi-visit.py
+++ b/scripts/qapi-visit.py
@@ -174,7 +174,7 @@ void visit_type_%(name)s(Visitor *m, %(name)s ** obj, const
char *name, Error **
''',
abbrev = de_camel_case(name).upper(),
enum = c_fun(de_camel_case(key),False).upper(),
- c_type=members[key],
+ c_type=type_name(members[key]),
c_name=c_fun(key))
ret += mcgen('''
--
1.8.1.4
- [Qemu-devel] [PULL 00/12] QMP queue, Luiz Capitulino, 2013/05/23
- [Qemu-devel] [PULL 01/12] qapi: qapi-types.py, native list support, Luiz Capitulino, 2013/05/23
- [Qemu-devel] [PULL 02/12] qapi: qapi-visit.py, fix list handling for union types,
Luiz Capitulino <=
- [Qemu-devel] [PULL 03/12] qapi: qapi-visit.py, native list support, Luiz Capitulino, 2013/05/23
- [Qemu-devel] [PULL 05/12] json-parser: fix handling of large whole number values, Luiz Capitulino, 2013/05/23
- [Qemu-devel] [PULL 06/12] qapi: add QMP input test for large integers, Luiz Capitulino, 2013/05/23
- [Qemu-devel] [PULL 04/12] qapi: enable generation of native list code, Luiz Capitulino, 2013/05/23
- [Qemu-devel] [PULL 07/12] qapi: fix visitor serialization tests for numbers/doubles, Luiz Capitulino, 2013/05/23
- [Qemu-devel] [PULL 12/12] monitor: allow to disable the default monitor, Luiz Capitulino, 2013/05/23
- [Qemu-devel] [PULL 08/12] qapi: add native list coverage for visitor serialization tests, Luiz Capitulino, 2013/05/23
- [Qemu-devel] [PULL 11/12] ui/input.c: replace magic numbers with macros, Luiz Capitulino, 2013/05/23
- [Qemu-devel] [PULL 10/12] qapi: add native list coverage for QMP input visitor tests, Luiz Capitulino, 2013/05/23
- [Qemu-devel] [PULL 09/12] qapi: add native list coverage for QMP output visitor tests, Luiz Capitulino, 2013/05/23