Re: [Qemu-devel] [PATCH v3 1/2] net: introduce RX_FILTER_CHANGED event

[Amos Kong]

On Thu, May 23, 2013 at 11:33:37AM -0400, Luiz Capitulino wrote:
> On Thu, 23 May 2013 17:57:56 +0300
> "Michael S. Tsirkin" <address@hidden> wrote:
> 
> > On Thu, May 23, 2013 at 08:52:16AM -0600, Eric Blake wrote:
> > > On 05/23/2013 08:43 AM, Michael S. Tsirkin wrote:
> > > >>> Please stress this is only for the NIC. It does not apply
> > > >>> to non-NIC netclients.
> > > >>
> > > >> Stress it in the event name too, please. I find RX_FILTER_CHANGED a bit
> > > >> generic.
> > > > 
> > > > What do you suggest?
> > > > NIC_RX_FILTER_CHANGED ?
> > > 
> > > Yes, that might work.  (And whatever name we bikeshed, insert it in the
> > > correct sorted order in the file)

Reasonable.

> > > >> Also, although I haven't reviewed the next patch yet, I think you
> > > >> should move the event trigger to this patch.
> > > > 
> > > > That's hard because of the flag that's shared with the query
> > > > command.
> > > 
> > > It's fine if this patch declares and sets the flag, but the event is
> > > one-shot until the next patch adds the query to clear the flag.  And
> > > again, the flag should be per-device, not global.

It works.

> > Maybe just merge both patches together. They are pretty small anyway.
> 
> That's what I was going to suggest if it's really hard to move the
> event to this patch.

Ok, I will merge those two patches together, and give a detail/whole
description in one patch.

-- 
                        Amos.