[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V2 2/5] block: move snapshot code in block.c to
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH V2 2/5] block: move snapshot code in block.c to block/snapshot.c |
Date: |
Fri, 24 May 2013 13:35:22 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, May 23, 2013 at 04:47:13PM +0800, Wenchao Xia wrote:
> -int bdrv_is_snapshot(BlockDriverState *bs)
> -{
> - return !!(bs->open_flags & BDRV_O_SNAPSHOT);
> -}
No need to respin, but this function has nothing to do with the other
functions. This function is about -drive snapshot=on, the others are
about internal snapshots.
It should not go into block/snapshot.c. At least it should be
documented as having nothing to do with internal snapshots.
Stefan
- [Qemu-devel] [PATCH V2 0/5] qapi and snapshot code clean up in block layer, Wenchao Xia, 2013/05/23
- [Qemu-devel] [PATCH V2 1/5] block: drop bs_snapshots global variable, Wenchao Xia, 2013/05/23
- [Qemu-devel] [PATCH V2 2/5] block: move snapshot code in block.c to block/snapshot.c, Wenchao Xia, 2013/05/23
- Re: [Qemu-devel] [PATCH V2 2/5] block: move snapshot code in block.c to block/snapshot.c,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH V2 3/5] block: move qmp and info dump related code to block/qapi.c, Wenchao Xia, 2013/05/23
- [Qemu-devel] [PATCH V2 4/5] util: add new function message_printf(), Wenchao Xia, 2013/05/23
- [Qemu-devel] [PATCH V2 5/5] block: dump to specified output for bdrv_snapshot_dump() and bdrv_image_info_dump(), Wenchao Xia, 2013/05/23