Re: [Qemu-devel] [PATCH v5 3/3] configure/Make: Build libfdt from submodule DTC

[Edgar E. Iglesias]

On Fri, May 24, 2013 at 03:16:00PM +0100, Peter Maydell wrote:
> On 22 April 2013 05:45, Peter Crosthwaite <address@hidden> wrote:
> > On Sun, Apr 21, 2013 at 11:16 PM, Paolo Bonzini <address@hidden> wrote:
> >> libfdt is not that portable, it doesn't use libtool to build shared
> >> libraries.
> >>
> >> Perhaps we can just build the static library?
> >>
> >
> > Seems reasonable, and got this working with fairly low effort.
> > Fix on list.
> 
> Hi -- can you point me at the fix? Did it get committed?
> I did a search of my mail archives but couldn't find anything
> that looked like it.
> 
> (I'm looking at making libfdt mandatory for softmmu targets, for
> which purpose we need to make sure all the libfdt build hiccups
> are fixed...)

Hi Peter,

I think it was this one:

Cheers,
Edgar

commit 9005a51b096272e1834638f8e184706548ee7364
Author: Peter Crosthwaite <address@hidden>
Date:   Mon Apr 22 14:40:49 2013 +1000

    Makefile: Don't build shared libfdt
    
    The submodule DTC should just build and use DTC as static (the whole
    motivation for using submod is lack of widespread distro support).
    
    The .so causes build failures on some platforms, so adjust the make
    target to just build the static lib.
    
    Signed-off-by: Peter Crosthwaite <address@hidden>
    Signed-off-by: Edgar E. Iglesias <address@hidden>

diff --git a/Makefile b/Makefile
index efb1c44..5140c19 100644
--- a/Makefile
+++ b/Makefile
@@ -149,7 +149,7 @@ DTC_MAKE_ARGS=-I$(SRC_PATH)/dtc VPATH=$(SRC_PATH)/dtc -C dtc
 DTC_CFLAGS=$(CFLAGS) $(extra_cflags) -I$(BUILD_DIR)/dtc -I$(SRC_PATH)/dtc -I$(S
 
 subdir-dtc:dtc/libfdt dtc/tests
-       $(call quiet-command,$(MAKE) $(DTC_MAKE_ARGS) CPPFLAGS="$(DTC_CFLAGS)" L
+       $(call quiet-command,$(MAKE) $(DTC_MAKE_ARGS) CPPFLAGS="$(DTC_CFLAGS)" L
 
 dtc/%:
        mkdir -p $@