Re: [Qemu-devel] [PATCH 17/30] memory: add address_space_translate

[Jan Kiszka]

On 2013-05-25 13:20, Paolo Bonzini wrote:
> Il 25/05/2013 12:19, Jan Kiszka ha scritto:
>>          addr -= section->offset_within_address_space;
>> -        len = MIN(section->size - addr, len);
>                      ^^^^^^^^^^^^^   ^^^^
> 
> This is the size of a section minus an offset in the section.
> 
>> +        diff = int128_sub(section->mr->size, int128_make64(addr));
>                              ^^^^^^^^^^^^^^^^^                ^^^^
> 
> This is the size of a region minus the same offset in the section.
> 
>> +        len = MIN(int128_get64(diff), len);
>>  
>>          /* Compute offset within MemoryRegion */
>>          addr += section->offset_within_region;
> 
> So this has to be moved above.

Right, fixed.

>  Do you have a branch pushed somewhere
> that I can test against?

git://git.kiszka.org/qemu.git queues/ioport

Jan

signature.asc
Description: OpenPGP digital signature