Re: [Qemu-devel] [PATCH 1/4] configure: Require libfdt for arm, ppc, microblaze softmmu targets

[Andreas Färber]

Am 24.05.2013 17:26, schrieb Peter Maydell:
> A number of our softmmu targets (PPC, ARM, Microblaze) now more or
> less require flattened device tree support for various board models
> to work correctly.  Make libfdt mandatory if the target list includes
> these, rather than building unhelpful half-functional binaries.
> 
> Signed-off-by: Peter Maydell <address@hidden>
> ---
>  configure |   20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/configure b/configure
> index 5ae7e4a..708c010 100755
> --- a/configure
> +++ b/configure
> @@ -2518,6 +2518,26 @@ fi
>  
>  ##########################################
>  # fdt probe
> +# fdt support is mandatory for at least some target architectures,
> +# so insist on it if we're building those system emulators.
> +fdt_required=no
> +for target in $target_list; do
> +  case $target in
> +    arm*softmmu|ppc*softmmu|microblaze*softmmu)

Assuming you'll apply this through your tree, it would be more
self-explanatory to use foo*-softmmu despite no practical difference.

I'm guessing arm* is in preparation for a future armeb-softmmu?

Otherwise looks good; still have testing pseries on my TODO list.

Andreas

> +      fdt_required=yes
> +    ;;
> +  esac
> +done
> +
> +if test "$fdt_required" = "yes"; then
> +  if test "$fdt" = "no"; then
> +    error_exit "fdt disabled but some requested targets require it." \
> +      "You can turn off fdt only if you also disable all the system 
> emulation" \
> +      "targets which need it (by specifying a cut down --target-list)."
> +  fi
> +  fdt=yes
> +fi
> +
>  if test "$fdt" != "no" ; then
>    fdt_libs="-lfdt"
>    cat > $TMPC << EOF

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg