[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH qom-cpu 4/4] memory_mapping: Move stubs to libqe
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH qom-cpu 4/4] memory_mapping: Move stubs to libqemustub.a |
Date: |
Tue, 28 May 2013 11:39:41 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 |
Am 23.05.2013 12:08, schrieb Paolo Bonzini:
> Il 22/05/2013 15:09, Andreas Färber ha scritto:
>> Allows us to drop CONFIG_NO_GET_MEMORY_MAPPING with its indirect
>> dependency on CONFIG_HAVE_GET_MEMORY_MAPPING in Makefile.target.
>>
>> Signed-off-by: Andreas Färber <address@hidden>
>> ---
>> Makefile.target | 2 --
>> stubs/Makefile.objs | 1 +
>> memory_mapping-stub.c => stubs/memory_mapping.c | 5 +++--
>> 3 files changed, 4 insertions(+), 4 deletions(-)
>> rename memory_mapping-stub.c => stubs/memory_mapping.c (85%)
[...]
>> diff --git a/memory_mapping-stub.c b/stubs/memory_mapping.c
>> similarity index 85%
>> rename from memory_mapping-stub.c
>> rename to stubs/memory_mapping.c
>> index c48ea44..4db2108 100644
>> --- a/memory_mapping-stub.c
>> +++ b/stubs/memory_mapping.c
>> @@ -11,8 +11,9 @@
>> *
>> */
>>
>> -#include "cpu.h"
>> -#include "exec/cpu-all.h"
>> +#include "qemu-common.h"
>> +#include "exec/cpu-common.h"
>> +#include "qom/cpu.h"
>> #include "sysemu/memory_mapping.h"
>>
>> int qemu_get_guest_memory_mapping(MemoryMappingList *list)
>>
>
> Patches 1-3 are fine.
Thanks.
> But I wonder if a better replacement for stubs is
> methods in CPU.
None of the functions I have moved from *-stub.c to stubs/ operate on a
single CPU, so now that the conflict with the kdump format support has
been resolved I'd like to move them as a step towards dropping
per-target configure changes for guest-memory-dump support.
With my note in the cover letter I was rather referring to
cpu_paging_enabled(), which is mandatory currently without any stub.
Do you have a concrete suggestion what else to do for these stubs?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg