[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 07/14] net: hub use lock to protect ports lis
From: |
liu ping fan |
Subject: |
Re: [Qemu-devel] [PATCH v1 07/14] net: hub use lock to protect ports list |
Date: |
Wed, 29 May 2013 09:41:42 +0800 |
On Tue, May 21, 2013 at 9:57 PM, Stefan Hajnoczi <address@hidden> wrote:
> On Tue, May 07, 2013 at 01:46:55PM +0800, Liu Ping Fan wrote:
>> From: Liu Ping Fan <address@hidden>
>>
>> Hub ports will run on multi-threads, so use lock to protect them.
>>
>> Signed-off-by: Liu Ping Fan <address@hidden>
>> ---
>> net/hub.c | 25 ++++++++++++++++++++++++-
>> 1 files changed, 24 insertions(+), 1 deletions(-)
>
> Does this rely on net queue re-entrancy detection? Otherwise we'll
> deadlock when slirp re-enters the net layer, for example for ARP
> requests.
>
Yes, you are right.
> I suggest moving this later in the patch series when the net queue is
> protected already.
>
Ok.
Thanks
Pingfan
> Stefan
- [Qemu-devel] [PATCH v1 00/14] port network layer onto glib, Liu Ping Fan, 2013/05/07
- [Qemu-devel] [PATCH v1 01/14] util: introduce gsource event abstraction, Liu Ping Fan, 2013/05/07
- [Qemu-devel] [PATCH v1 02/14] net: introduce bind_ctx to NetClientInfo, Liu Ping Fan, 2013/05/07
- [Qemu-devel] [PATCH v1 03/14] net: port vde onto GSource, Liu Ping Fan, 2013/05/07
- [Qemu-devel] [PATCH v1 04/14] net: port socket to GSource, Liu Ping Fan, 2013/05/07
- [Qemu-devel] [PATCH v1 05/14] net: port tap onto GSource, Liu Ping Fan, 2013/05/07
- [Qemu-devel] [PATCH v1 06/14] net: port tap-win32 onto GSource, Liu Ping Fan, 2013/05/07
- [Qemu-devel] [PATCH v1 07/14] net: hub use lock to protect ports list, Liu Ping Fan, 2013/05/07
- [Qemu-devel] [PATCH v1 08/14] net: introduce lock to protect NetQueue, Liu Ping Fan, 2013/05/07
- [Qemu-devel] [PATCH v1 09/14] net: introduce lock to protect NetClientState's peer's access, Liu Ping Fan, 2013/05/07
- [Qemu-devel] [PATCH v1 10/14] net: make netclient re-entrant with refcnt, Liu Ping Fan, 2013/05/07
- [Qemu-devel] [PATCH v1 11/14] slirp: make timeout local, Liu Ping Fan, 2013/05/07
- [Qemu-devel] [PATCH v1 12/14] slirp: make slirp event dispatch based on slirp instance, not global, Liu Ping Fan, 2013/05/07
- [Qemu-devel] [PATCH v1 13/14] slirp: handle race condition, Liu Ping Fan, 2013/05/07
- [Qemu-devel] [PATCH v1 14/14] slirp: use lock to protect the slirp_instances, Liu Ping Fan, 2013/05/07
- Re: [Qemu-devel] [PATCH v1 00/14] port network layer onto glib, Stefan Hajnoczi, 2013/05/15