[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/16] qemu-io: Split off commands to qemu-io-cm
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 06/16] qemu-io: Split off commands to qemu-io-cmds.c |
Date: |
Wed, 29 May 2013 14:29:50 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
On 05/28/2013 09:27 AM, Kevin Wolf wrote:
> This is the implementation of all qemu-io commands that make sense to be
> called from the qemu monitor, i.e. everything except open, close and
> quit.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> Makefile | 2 +-
> qemu-io-cmds.c | 1835
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> qemu-io.c | 1817 +------------------------------------------------------
> 3 files changed, 1838 insertions(+), 1816 deletions(-)
> create mode 100644 qemu-io-cmds.c
I checked the bulk of this patch via:
$ diff -u <(sed -n '/^-/ s///p' file) <(sed -n '/^\+/ s///p' file)
The bulk of the patch is blind code motion plus a bit of touchup; I did
however spot one case where you were too eager in your search-and-replace:
* Memory allocation helpers.
*
- * Make sure memory is aligned by default, or purposefully misaligned if
+ * Make sure memory is aligned by default, or purposefully
qemuio_misaligned if
* that is specified on the command line.
> +
> +int qemuio_misalign;
Should this variable be typed 'bool'?
Other than that,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 05/16] qemu-io: Don't use global bs in command implementations, (continued)
- [Qemu-devel] [PATCH 05/16] qemu-io: Don't use global bs in command implementations, Kevin Wolf, 2013/05/28
- [Qemu-devel] [PATCH 08/16] qemu-io: Move 'help' function, Kevin Wolf, 2013/05/28
- [Qemu-devel] [PATCH 07/16] qemu-io: Factor out qemuio_command, Kevin Wolf, 2013/05/28
- [Qemu-devel] [PATCH 09/16] qemu-io: Move 'quit' function, Kevin Wolf, 2013/05/28
- [Qemu-devel] [PATCH 06/16] qemu-io: Split off commands to qemu-io-cmds.c, Kevin Wolf, 2013/05/28
- Re: [Qemu-devel] [PATCH 06/16] qemu-io: Split off commands to qemu-io-cmds.c,
Eric Blake <=
- [Qemu-devel] [PATCH 10/16] qemu-io: Move qemu_strsep() to cutils.c, Kevin Wolf, 2013/05/28
- [Qemu-devel] [PATCH 11/16] qemu-io: Move functions for registering and running commands, Kevin Wolf, 2013/05/28
- [Qemu-devel] [PATCH 12/16] qemu-io: Move command_loop() and friends, Kevin Wolf, 2013/05/28
- [Qemu-devel] [PATCH 13/16] qemu-io: Move remaining helpers from cmd.c, Kevin Wolf, 2013/05/28
- [Qemu-devel] [PATCH 15/16] qemu-io: Use the qemu version for -V, Kevin Wolf, 2013/05/28
- [Qemu-devel] [PATCH 16/16] Make qemu-io commands available in the monitor, Kevin Wolf, 2013/05/28