[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/16] qemu-io: Factor out qemuio_command
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 07/16] qemu-io: Factor out qemuio_command |
|
Date: |
Wed, 29 May 2013 15:11:44 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
On 05/28/2013 09:27 AM, Kevin Wolf wrote:
> It's duplicated code. Move it to qemu-io-cmds.c because it's not
> dependent on any static data of the qemu-io tool.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> cmd.c | 43 +++++--------------------------------------
> cmd.h | 3 ++-
> qemu-io-cmds.c | 24 ++++++++++++++++++++++++
> 3 files changed, 31 insertions(+), 39 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 03/16] qemu-io: Make cvtnum() a wrapper around strtosz_suffix(), (continued)
- [Qemu-devel] [PATCH 03/16] qemu-io: Make cvtnum() a wrapper around strtosz_suffix(), Kevin Wolf, 2013/05/28
- [Qemu-devel] [PATCH 04/16] qemu-io: Handle cvtnum() errors in 'alloc', Kevin Wolf, 2013/05/28
- [Qemu-devel] [PATCH 05/16] qemu-io: Don't use global bs in command implementations, Kevin Wolf, 2013/05/28
- [Qemu-devel] [PATCH 08/16] qemu-io: Move 'help' function, Kevin Wolf, 2013/05/28
- [Qemu-devel] [PATCH 07/16] qemu-io: Factor out qemuio_command, Kevin Wolf, 2013/05/28
- Re: [Qemu-devel] [PATCH 07/16] qemu-io: Factor out qemuio_command,
Eric Blake <=
- [Qemu-devel] [PATCH 09/16] qemu-io: Move 'quit' function, Kevin Wolf, 2013/05/28
- [Qemu-devel] [PATCH 06/16] qemu-io: Split off commands to qemu-io-cmds.c, Kevin Wolf, 2013/05/28
- [Qemu-devel] [PATCH 10/16] qemu-io: Move qemu_strsep() to cutils.c, Kevin Wolf, 2013/05/28
- [Qemu-devel] [PATCH 11/16] qemu-io: Move functions for registering and running commands, Kevin Wolf, 2013/05/28
- [Qemu-devel] [PATCH 12/16] qemu-io: Move command_loop() and friends, Kevin Wolf, 2013/05/28
- [Qemu-devel] [PATCH 13/16] qemu-io: Move remaining helpers from cmd.c, Kevin Wolf, 2013/05/28