[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [SeaBIOS PATCH] boot: fix fw_dev_path pattern for q35-p
|
From: |
Kevin O'Connor |
|
Subject: |
Re: [Qemu-devel] [SeaBIOS PATCH] boot: fix fw_dev_path pattern for q35-pcihost |
|
Date: |
Wed, 29 May 2013 21:25:19 -0400 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, May 29, 2013 at 10:33:54AM +0800, Amos Kong wrote:
> On Tue, May 28, 2013 at 06:59:02PM -0400, Kevin O'Connor wrote:
> > On Tue, May 28, 2013 at 08:28:14PM +0800, Amos Kong wrote:
> > > -#define FW_PCI_DOMAIN "/address@hidden"
> > > +#define FW_PCI_DOMAIN "/address@hidden"
> >
> > The seabios pattern matching code isn't that sophisticated - I think
> > this could end up doing something unexpected. Why does it need to
> > change?
>
> If we start a guest with default machine type (pc-i440fx), the prefix
> of bootindex string is "/address@hidden", if we start guest with -M q35,
> the prefix will become "/address@hidden".
>
> We only match "/address@hidden" in seabios, it causes boot priority of q35
> devices could not be changed.
>
> We could not change TYPE_Q35_HOST_DEVICE to 'pci' in qemu to adapt
> seabios, so fix the pattern.
It really can't be changed?
> I see glob_prefix() is not powerful, "/address@hidden" & "/address@hidden" all
> work.
>
> Or change TYPE_Q35_HOST_DEVICE to "pci-q35" in qemu, and use
> "/address@hidden" in seabios ?
That would be preferable.
-Kevin