|
From: | Gerd Hoffmann |
Subject: | Re: [Qemu-devel] [PATCH v2 2/5] pci: store PCI hole ranges in guestinfo structure |
Date: | Thu, 30 May 2013 14:16:13 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130513 Thunderbird/17.0.6 |
Hi, > + } else { > + guest_info->pci_info.w64.begin = 0x100000000ULL + above_4g_mem_size; > + guest_info->pci_info.w64.end = guest_info->pci_info.w64.begin + > + (0x1ULL << 62); Doesn't this give unaligned windows? > + /* Set PCI window size the way seabios has always done it. */ > + /* TODO: consider just starting at below_4g_mem_size */ Used to be that way. Was changed for alignment reasons (i.e. 1G window starts at 1G border etc). cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |