Re: [Qemu-devel] [PATCH 2/2] firmware_abi: move to include/hw/nvram/

[Andreas Färber]

Am 30.05.2013 11:30, schrieb Michael S. Tsirkin:
> firmware_abi.h with structs for OpenBIOS landed in hw/sparc/ by mistake
> - move it to hw/nvram/ alongside fw_cfg.h.  In addition to sparc it's
> included from ppc mac_nvram.c and will need to include it from prep.c in
> the future.
> 
> Cc: Andreas Färber <address@hidden>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
>  hw/sparc/sun4m.c                         |  2 +-
>  hw/sparc64/sun4u.c                       |  2 +-
>  include/hw/nvram/openbios_firmware_abi.h | 73 
> ++++++++++++++++++++++++++++++++
>  include/hw/sparc/firmware_abi.h          | 73 
> --------------------------------
>  4 files changed, 75 insertions(+), 75 deletions(-)
>  create mode 100644 include/hw/nvram/openbios_firmware_abi.h
>  delete mode 100644 include/hw/sparc/firmware_abi.h

Thanks for picking my suggestion up! Same applies as for other patch: In
general

Acked-by: Andreas Färber <address@hidden>

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg