[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 5/5] pc: pci-info add compat support
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH v2 5/5] pc: pci-info add compat support |
Date: |
Thu, 30 May 2013 18:32:19 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130513 Thunderbird/17.0.6 |
On 05/30/13 13:07, Michael S. Tsirkin wrote:
> /* PC hardware initialisation */
> static void pc_init1(MemoryRegion *system_memory,
> @@ -122,6 +122,7 @@ static void pc_init1(MemoryRegion *system_memory,
> }
>
> guest_info = pc_guest_info_init(below_4g_mem_size, above_4g_mem_size);
> + guest_info->compat_v1_5 = guest_info_compat_v1_5;
I believe I can see the advantage of delaying this "compat_v1_5" until
init-done-notifier time: init code gradually building up / rewriting
guest_info doesn't have to tiptoe around conditions.
Style: would it be worth passing "guest_info_compat_v1_5" as a parameter
to pc_guest_info_init()? Currently you have an _init() function that
partially initializes the struct, and right after _init() returns you
fill in what's still missing form basic initialization.
No more comments for the series.
Thanks,
Laszlo
- Re: [Qemu-devel] [PATCH v2 2/5] pci: store PCI hole ranges in guestinfo structure, (continued)
Re: [Qemu-devel] [PATCH v2 2/5] pci: store PCI hole ranges in guestinfo structure, Laszlo Ersek, 2013/05/30
Re: [Qemu-devel] [PATCH v2 2/5] pci: store PCI hole ranges in guestinfo structure, Hu Tao, 2013/05/30
[Qemu-devel] [PATCH v2 3/5] pc: pass PCI hole ranges to Guests, Michael S. Tsirkin, 2013/05/30
[Qemu-devel] [PATCH v2 4/5] pc: add 1.6 compat type, Michael S. Tsirkin, 2013/05/30
[Qemu-devel] [PATCH v2 5/5] pc: pci-info add compat support, Michael S. Tsirkin, 2013/05/30
- Re: [Qemu-devel] [PATCH v2 5/5] pc: pci-info add compat support,
Laszlo Ersek <=