Re: [Qemu-devel] [PATCH v5 08/11] blockdev: allow BdrvActionOps->commit() to be NULL

[Eric Blake]

On 05/30/2013 06:34 AM, Stefan Hajnoczi wrote:
> Some QMP 'transaction' types don't need to do anything on .commit().
> Make .commit() optional just like .abort().
> 
> The "drive-backup" action will take advantage of this, it only needs to
> cancel the block job on .abort().  Other block job actions will probably
> follow the same pattern, so allow .commit() to be NULL.
> 
> Suggested-by: Eric Blake <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
>  blockdev.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

Is it worth enforcing that at least one of commit or abort is supplied
(that is, assert if the user codes up an action that has neither
callback)?  Or is that just overkill?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature