Re: [Qemu-devel] [PATCH v2 1/1] configure: dtc: Probe for libfdt_env.h

[Paolo Bonzini]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Il 31/05/2013 05:32, David Gibson ha scritto:
>>> Then again, although we certainly want to keep changes which 
>>> require updates to libfdt_env.h rare, I'm not going to rule
>>> out extensions to libfdt which add new (minor) external 
>>> dependencies, and therefore changes to libfdt_env.h.
>>> 
>>> That said, I did put my correction a bit too strongly.  While 
>>> libfdt_env.h is notionally always provided by the surrounding 
>>> environment, if the packaged one works for your environment, 
>>> it's probably a good idea to use it.
>> 
>> I think we should be able to consider QEMU as normal enough to 
>> use prepacked DTC and just fix the commit message?
> 
> I concur.

Please don't.  Fedora is not going to use the bundled dtc because of a
policy against bundling, and Fedora's dtc package doesn't include
libfdt_env.h.

If David says that the changes are rare enough, let's just fix the
bundled libfdt_env.h.

Paolo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJRqF6TAAoJEBvWZb6bTYbycyYQAJswKGTnYtac7eJb2s7+I48R
TwX8NDbsLXyuyrBRNtwK/yLuSIdXKZeyhXmJNWHtvf2KH0aSgP3+FKHnoOrc0m/U
7ZMfIqquDkqx0AspSIeEmp3Q+i03oyI+nRzop9tpyBAPDGQm6VsAJzggwEBjfAUJ
+Ww+1g4UTfF/9Nwjj9EMryS85gMQLwd52t2mIcxcEN22XucZbuF6OmFOk4Tt7EW1
ZbBMm+J8vFOFu77ejpRE03SsfN6vd2FDFgyo+nTGay89hlVKxUbSkmxsmVqcwpqb
rV9fk5r266+50SW5X/EzJLAyVtilXZSDB84wSRQFVP8vUKKGwxz1q56rEpuwfdBW
JYB69woigiC4RmYtgueGy2tnP5xSTXKopo5QjKyjcyJlqpF1xQEd8YVh5gKBYKxG
Hla2uEM/QOmMFR0jf9kj0kyIF2seK7PGMA3M+W5OFyB1YKWaVJIjFW/r13g8Zfjb
MkA2LirNWzLo5H/mgkYLrC2sa9e6zVbc7+IPgj7t0mIBOQN1L4V50n81xlQNalGq
/NGuyz7v3qbtQVCKbS2C+Jtoq2/uvHyY0jd7AytRRRCO9KA/mine1gpXX96T9PXB
kjJO3ASHEJLT8GblsFDtb9NWHKoO/jrUOWuKM/4OmL4aFdSTYY3+z3/+5PlJhhWY
jPFsbspFp+aEqJPox3kT
=znA9
-----END PGP SIGNATURE-----