[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/21] exec: Resolve subpages in one step except
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 04/21] exec: Resolve subpages in one step except for IOTLB fills |
Date: |
Fri, 31 May 2013 14:58:29 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
On 05/30/2013 02:16 PM, Paolo Bonzini wrote:
> static MemoryRegionSection *address_space_lookup_region(AddressSpace *as,
> - hwaddr addr)
> + hwaddr addr,
> + bool resolve_subpage)
> {
> - return phys_page_find(as->dispatch, addr >> TARGET_PAGE_BITS);
> + MemoryRegionSection *section;
> + subpage_t *subpage;
> +
> + section = phys_page_find(as->dispatch, addr >> TARGET_PAGE_BITS);
> + if (resolve_subpage && section->mr->subpage) {
> + subpage = container_of(section->mr, subpage_t, iomem);
> + section = &phys_sections[subpage->sub_section[SUBPAGE_IDX(addr)]];
> + }
> + return section;
> }
Was there somewhere else that no longer needs to check phys_sections?
Or does that get eliminated in the course of subsequent patches?
r~
- [Qemu-devel] [PATCH 00/21] Memory/IOMMU patches, part 3: IOMMU implementation, Paolo Bonzini, 2013/05/30
- [Qemu-devel] [PATCH 01/21] memory: Introduce address_space_lookup_region, Paolo Bonzini, 2013/05/30
- [Qemu-devel] [PATCH 02/21] memory: move private types to exec.c, Paolo Bonzini, 2013/05/30
- [Qemu-devel] [PATCH 03/21] exec: Allow unaligned address_space_rw, Paolo Bonzini, 2013/05/30
- [Qemu-devel] [PATCH 04/21] exec: Resolve subpages in one step except for IOTLB fills, Paolo Bonzini, 2013/05/30
- Re: [Qemu-devel] [PATCH 04/21] exec: Resolve subpages in one step except for IOTLB fills,
Richard Henderson <=
- [Qemu-devel] [PATCH 05/21] exec: Implement subpage_read/write via address_space_rw, Paolo Bonzini, 2013/05/30
- [Qemu-devel] [PATCH 07/21] Revert "memory: limit sections in the radix tree to the actual address space size", Paolo Bonzini, 2013/05/30
- [Qemu-devel] [PATCH 06/21] exec: return MemoryRegion from address_space_translate, Paolo Bonzini, 2013/05/30
- [Qemu-devel] [PATCH 08/21] Revert "s390x: reduce TARGET_PHYS_ADDR_SPACE_BITS to 62", Paolo Bonzini, 2013/05/30
- [Qemu-devel] [PATCH 09/21] exec: reorganize mem_add to match Int128 version, Paolo Bonzini, 2013/05/30
- [Qemu-devel] [PATCH 10/21] memory: make section size a 128-bit integer, Paolo Bonzini, 2013/05/30