Re: [Qemu-devel] [PATCH v2 1/1] configure: dtc: Probe for libfdt_env.h

[David Gibson]

On Fri, May 31, 2013 at 10:25:55AM +0200, Paolo Bonzini wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Il 31/05/2013 05:32, David Gibson ha scritto:
> >>> Then again, although we certainly want to keep changes which 
> >>> require updates to libfdt_env.h rare, I'm not going to rule
> >>> out extensions to libfdt which add new (minor) external 
> >>> dependencies, and therefore changes to libfdt_env.h.
> >>> 
> >>> That said, I did put my correction a bit too strongly.  While 
> >>> libfdt_env.h is notionally always provided by the surrounding 
> >>> environment, if the packaged one works for your environment, 
> >>> it's probably a good idea to use it.
> >> 
> >> I think we should be able to consider QEMU as normal enough to 
> >> use prepacked DTC and just fix the commit message?
> > 
> > I concur.
> 
> Please don't.  Fedora is not going to use the bundled dtc because of a
> policy against bundling, and Fedora's dtc package doesn't include
> libfdt_env.h.

Yeah, that makes Fedora's dtc (well, libfdt) package broken.

> If David says that the changes are rare enough, let's just fix the
> bundled libfdt_env.h.

That's definitely not right.  If you're using an externally packagd
build of libfdt, you must use that external package's libfdt_env.h as
well (which in this case is the default version).

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: Digital signature