[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] tcg-ppc64: Fix RLDCL opcode
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/4] tcg-ppc64: Fix RLDCL opcode |
|
Date: |
Mon, 03 Jun 2013 07:28:00 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
On 06/02/2013 05:27 AM, Anton Blanchard wrote:
> The rldcl instruction doesn't have an sh field, so the minor opcode
> of 8 is actually 4 when using the XO30 macro.
>
> Cc: address@hidden
> Signed-off-by: Anton Blanchard <address@hidden>
> ---
>
> Index: b/tcg/ppc64/tcg-target.c
> ===================================================================
> --- a/tcg/ppc64/tcg-target.c
> +++ b/tcg/ppc64/tcg-target.c
> @@ -357,7 +357,7 @@ static int tcg_target_const_match (tcg_t
> #define RLDICL XO30( 0)
> #define RLDICR XO30( 1)
> #define RLDIMI XO30( 3)
> -#define RLDCL XO30( 8)
> +#define RLDCL XO30( 4)
Oops.
But that suggests then that we ought not be using XO30.
Or at least adding a comment.
r~