Re: [Qemu-devel] [PATCH v5 1/4] Add i.MX FEC Ethernet emulator

[Peter Maydell]

On 8 May 2013 09:28, Jean-Christophe DUBOIS <address@hidden> wrote:
> --- a/include/hw/arm/imx.h
> +++ b/include/hw/arm/imx.h
> @@ -23,12 +23,10 @@ typedef enum  {
>
>  uint32_t imx_clock_frequency(DeviceState *s, IMXClk clock);
>
> -void imx_timerp_create(const hwaddr addr,
> -                      qemu_irq irq,
> -                      DeviceState *ccm);
> -void imx_timerg_create(const hwaddr addr,
> -                      qemu_irq irq,
> -                      DeviceState *ccm);
> +void imx_timerp_create(const hwaddr addr, qemu_irq irq, DeviceState *ccm);
>
> +void imx_timerg_create(const hwaddr addr, qemu_irq irq, DeviceState *ccm);
> +

Please don't include random reformatting inside a patch
doing something else.

> +DeviceState *imx_fec_create(int nic, const hwaddr base, qemu_irq irq);

thanks
-- PMM