[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V13 3/6] qmp: add recursive member in ImageInfo
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH V13 3/6] qmp: add recursive member in ImageInfo |
Date: |
Wed, 5 Jun 2013 12:56:52 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, May 27, 2013 at 09:28:59AM +0800, Wenchao Xia wrote:
> δΊ 2013-5-26 0:10, Eric Blake ει:
> >On 05/24/2013 10:24 PM, Wenchao Xia wrote:
> >> void bdrv_query_image_info(BlockDriverState *bs,
> >> ImageInfo **p_info,
> >> Error **errp)
> >>diff --git a/qapi-schema.json b/qapi-schema.json
> >>index ef1f657..a02999d 100644
> >>--- a/qapi-schema.json
> >>+++ b/qapi-schema.json
> >>@@ -236,6 +236,8 @@
> >> #
> >> # @snapshots: #optional list of VM snapshots
> >> #
> >>+# @backing-image: #optional info of the backing image (since 1.6)
> >>+#
> >> # Since: 1.3
> >> #
> >> ##
> >>@@ -245,7 +247,8 @@
> >> '*actual-size': 'int', 'virtual-size': 'int',
> >> '*cluster-size': 'int', '*encrypted': 'bool',
> >> '*backing-filename': 'str', '*full-backing-filename': 'str',
> >>- '*backing-filename-format': 'str', '*snapshots':
> >>['SnapshotInfo'] } }
> >>+ '*backing-filename-format': 'str', '*snapshots':
> >>['SnapshotInfo'],
> >>+ '*backing-image': 'ImageInfo' } }
> >
> >The API change looks fine, except there is no code change to actually
> >populate the new field. This hunk should probably be squashed with the
> >patch that implements the field. Also, are you missing any changes to
> >qmp-commands.hx?
> >
> nop, in next patch qmp-commands.hx parts is added. Just to make
> review easier, after that I am fine to squash them.
The qapi change should be together with the code that implements it. I
need to see the code in order to review the documentation change.
Stefan
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH V13 3/6] qmp: add recursive member in ImageInfo,
Stefan Hajnoczi <=