Re: [Qemu-devel] [PATCH 00/16] Make qemu-io commands available in the monitor

[Stefan Hajnoczi]

On Tue, May 28, 2013 at 05:27:20PM +0200, Kevin Wolf wrote:
> This is a prerequisite for some kind of tests. It involves reorganising the
> qemu-io code so that the command part can be separated and doesn't pollute the
> global namespace any more, so we can link it with qemu.
> 
> Kevin Wolf (16):
>   qemu-io: Remove unused args_command
>   cutils: Support 'P' and 'E' suffixes in strtosz()
>   qemu-io: Make cvtnum() a wrapper around strtosz_suffix()
>   qemu-io: Handle cvtnum() errors in 'alloc'
>   qemu-io: Don't use global bs in command implementations
>   qemu-io: Split off commands to qemu-io-cmds.c
>   qemu-io: Factor out qemuio_command
>   qemu-io: Move 'help' function
>   qemu-io: Move 'quit' function
>   qemu-io: Move qemu_strsep() to cutils.c
>   qemu-io: Move functions for registering and running commands
>   qemu-io: Move command_loop() and friends
>   qemu-io: Move remaining helpers from cmd.c
>   qemu-io: Interface cleanup
>   qemu-io: Use the qemu version for -V
>   Make qemu-io commands available in the monitor
> 
>  Makefile                   |    2 +-
>  Makefile.objs              |    1 +
>  blockdev.c                 |   15 +
>  cmd.c                      |  612 -------------
>  cmd.h                      |   79 --
>  hmp-commands.hx            |   16 +
>  hmp.c                      |   10 +
>  hmp.h                      |    1 +
>  include/qemu-common.h      |    3 +
>  include/qemu-io.h          |   46 +
>  monitor.c                  |    8 +-
>  qapi-schema.json           |   16 +
>  qemu-img.c                 |   10 +-
>  qemu-io-cmds.c             | 2118 
> ++++++++++++++++++++++++++++++++++++++++++++
>  qemu-io.c                  | 1988 ++++-------------------------------------
>  qmp-commands.hx            |   28 +
>  tests/qemu-iotests/049.out |    8 +-
>  util/cutils.c              |   25 +
>  18 files changed, 2466 insertions(+), 2520 deletions(-)
>  delete mode 100644 cmd.c
>  delete mode 100644 cmd.h
>  create mode 100644 include/qemu-io.h
>  create mode 100644 qemu-io-cmds.c

Mostly good but I think cmd.c should be preserved.  It's a generic
command-line dispatcher and shouldn't be squashed into qemu-io-cmds.c.