[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] fix Coverity scan SIGN_EXTENSION error
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH] fix Coverity scan SIGN_EXTENSION error |
|
Date: |
Fri, 07 Jun 2013 00:18:43 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 |
Am 06.06.2013 17:12, schrieb Gerd Hoffmann:
> Cc: Markus Armbruster <address@hidden>
> Signed-off-by: Gerd Hoffmann <address@hidden>
Please indicate in the subject that this is about qxl when queuing. :)
Cheers,
Andreas
> ---
> hw/display/qxl-render.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/display/qxl-render.c b/hw/display/qxl-render.c
> index f511a62..269b1a7 100644
> --- a/hw/display/qxl-render.c
> +++ b/hw/display/qxl-render.c
> @@ -199,7 +199,7 @@ static QEMUCursor *qxl_cursor(PCIQXLDevice *qxl,
> QXLCursor *cursor)
> c->hot_y = cursor->header.hot_spot_y;
> switch (cursor->header.type) {
> case SPICE_CURSOR_TYPE_ALPHA:
> - size = cursor->header.width * cursor->header.height *
> sizeof(uint32_t);
> + size = sizeof(uint32_t) * cursor->header.width *
> cursor->header.height;
> memcpy(c->data, cursor->chunk.data, size);
> if (qxl->debug > 2) {
> cursor_print_ascii_art(c, "qxl/alpha");
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg