Re: [Qemu-devel] [PATCH v1 1/5] intc/xilinx_intc: Use qemu_set_irq

[Peter Crosthwaite]

email accidentally sent with cc supression, so cc qemu-trivial as intended.

On Fri, Jun 7, 2013 at 12:38 PM,  <address@hidden> wrote:
> From: Peter Crosthwaite <address@hidden>
>
> Use qemu_set_irq rather than if-elsing qemu_irq_(lower|raise). No
> functional change, just reduces verbosity.
>
> Cc: address@hidden
>
> Signed-off-by: Peter Crosthwaite <address@hidden>
> ---
>
>  hw/intc/xilinx_intc.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/hw/intc/xilinx_intc.c b/hw/intc/xilinx_intc.c
> index b106e72..5df7008 100644
> --- a/hw/intc/xilinx_intc.c
> +++ b/hw/intc/xilinx_intc.c
> @@ -66,11 +66,7 @@ static void update_irq(struct xlx_pic *p)
>          i = ~0;
>
>      p->regs[R_IVR] = i;
> -    if ((p->regs[R_MER] & 1) && p->regs[R_IPR]) {
> -        qemu_irq_raise(p->parent_irq);
> -    } else {
> -        qemu_irq_lower(p->parent_irq);
> -    }
> +    qemu_set_irq(p->parent_irq, (p->regs[R_MER] & 1) && p->regs[R_IPR]);
>  }
>
>  static uint64_t
> --
> 1.8.3.rc1.44.gb387c77.dirty
>