Re: [Qemu-devel] [PATCH qom-cpu 07/59] cpus: Simplify set_numa_modes()

[li guang]

Reviewed-by: liguang <address@hidden>

在 2013-06-09日的 21:12 +0200，Andreas Färber写道：
> Use new qemu_for_each_cpu().
> 
> Signed-off-by: Andreas Färber <address@hidden>
> ---
>  cpus.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/cpus.c b/cpus.c
> index 1babecf..24ee974 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -1188,22 +1188,22 @@ static void tcg_exec_all(void)
>      exit_request = 0;
>  }
>  
> -void set_numa_modes(void)
> +static void set_one_numa_mode(CPUState *cpu, void *data)
>  {
> -    CPUArchState *env;
> -    CPUState *cpu;
>      int i;
>  
> -    for (env = first_cpu; env != NULL; env = env->next_cpu) {
> -        cpu = ENV_GET_CPU(env);
> -        for (i = 0; i < nb_numa_nodes; i++) {
> -            if (test_bit(cpu->cpu_index, node_cpumask[i])) {
> -                cpu->numa_node = i;
> -            }
> +    for (i = 0; i < nb_numa_nodes; i++) {
> +        if (test_bit(cpu->cpu_index, node_cpumask[i])) {
> +            cpu->numa_node = i;
>          }
>      }
>  }
>  
> +void set_numa_modes(void)
> +{
> +    qemu_for_each_cpu(set_one_numa_mode, NULL);
> +}
> +
>  void list_cpus(FILE *f, fprintf_function cpu_fprintf, const char *optarg)
>  {
>      /* XXX: implement xxx_cpu_list for targets that still miss it */