Re: [Qemu-devel] [PATCH qom-cpu 02/59] kvm: Change cpu_synchronize_state() argument to CPUState

[Andreas Färber]

Am 10.06.2013 04:00, schrieb li guang:
> 在 2013-06-09日的 21:12 +0200，Andreas Färber写道：
>> Change Monitor::mon_cpu to CPUState as well.
>> In cpu_sychronize_all_states() use qemu_for_each_cpu() now.
> 
> Oh, s/sychronize/synchronize

Fixed, thanks for noticing!

> with that,
> Reviewed-by: liguang <address@hidden>

Thanks. Unfortunately this patch touches on the question of what to do
with CPU loops, so I'll wait for Markus and Gleb/Paolo to weigh in.

>> In dump_init() use cpu_synchronize_all_states().

Was obsoleted by having extracted that hunk into my preceding series:
http://patchwork.ozlabs.org/patch/250060/

Andreas

>>
>> Signed-off-by: Andreas Färber <address@hidden>
>> ---
>>  cpus.c                  | 13 +++++++------
>>  gdbstub.c               |  8 ++++----
>>  hw/i386/kvm/apic.c      |  2 +-
>>  hw/i386/kvmvapic.c      |  4 ++--
>>  hw/misc/vmport.c        |  2 +-
>>  hw/ppc/ppce500_spin.c   |  2 +-
>>  include/sysemu/kvm.h    |  4 ++--
>>  monitor.c               |  6 +++---
>>  target-i386/helper.c    |  4 ++--
>>  target-i386/kvm.c       |  2 +-
>>  target-ppc/mmu-hash64.c |  2 +-
>>  target-ppc/translate.c  |  2 +-
>>  target-s390x/kvm.c      |  9 +++++----
>>  13 files changed, 31 insertions(+), 29 deletions(-)

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg